Hi,

Having upgraded from Commerce v8.16.1 to v12.10, I am seeing some issues regarding the application of discount codes (we're using the legacy promotion system still).

Having followed through the code comparing it to the process of the original. It seems that after running the 'cart.RunWorkflow' method, where the workflow passed as a parameter is 'ValidateCart', the discount has not been applied in the OrderForm post-workflow.

The code looks like this (removed some unimportant parts for brevity) -

var ch = new CartHelper(Cart.DefaultName);

var matchedDiscount = PromotionManager.GetPromotionDto()
                                     .Promotion.AsEnumerable()
                                     .ToList()
                                     .Where(x => x.CouponCode == code)
                                     .ToList()
                                     .FirstOrDefault();

MarketingContext.Current.AddCouponToMarketingContext(code);
                        ch.OrderForm.EnsureLineItemsOnShipment();

messages += RunWorkflowAndReturnFormattedMessage(ch.Cart, OrderGroupWorkflowManager.CartValidateWorkflowName);

ch.Cart.AcceptChanges();

With the event method doing the following -

public static string RunWorkflowAndReturnFormattedMessage(Cart cart, string workflowName)
        {
            if (cart == null)
            {
                return string.Empty;
            }

            var returnString = string.Empty;

            cart.ProviderId = "FrontEnd";

            try
            {
                var results = cart.RunWorkflow(workflowName);
                var resultsMessages = GetWarningsFromWorkflowResult(results);
                var enumerable = resultsMessages as string[] ?? resultsMessages.ToArray();
                if (enumerable.Any())
                {
                    returnString = enumerable.Aggregate((current, result) => current + (result + "
"));
                }

                if (returnString.IndexOf("exception") >= 0)
                {
                    returnString = ValidationMessage.Error;
                }
                else if (returnString.Contains("lineitemremoved"))
                {
                    returnString = ValidationMessage.StockChange;
                }
                else if (!string.IsNullOrEmpty(returnString))
                {
                    returnString = ValidationMessage.Other;
                }

                return returnString;
            }
            catch (Exception aore)
            {
                return aore.FormatMessageRecursive(Environment.NewLine);
            }
        }

Is there anything obvious I've missed, it was a large upgrade so there's a chance I've missed some kind of breaking change/rework?

Cheers,

James